Messages in this thread | | | Date | Thu, 7 Jan 2021 14:22:27 +0100 (CET) | From | Miroslav Benes <> | Subject | Re: [PATCH 3/3] objtool: Support stack layout changes in alternatives |
| |
On Tue, 22 Dec 2020, Josh Poimboeuf wrote:
> BTW, another benefit of these changes is that, thanks to some related > cleanups (new fake nops and alt_group struct) objtool can finally be rid > of fake jumps, which were a constant source of headaches.
\o/
You may also want to remove/edit the comment right before handle_group_alt() now that fake jumps are gone.
Anyway, I walked through the patch (set) and I think it should work fine (but I am not confident enough to give it Reviewed-by. My head spins :)). I even like the change.
Also, 1/3 is a benefit on its own, so if nothing else, it could go in.
Regards Miroslav
| |