lkml.org 
[lkml]   [2021]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 4/5] csky: Fixup asm/cmpxchg.h with correct ordering barrier
On Sun, Dec 20, 2020 at 03:39:22PM +0000, guoren@kernel.org wrote:


> +#define cmpxchg(ptr, o, n) \
> +({ \
> + __typeof__(*(ptr)) __ret; \
> + __smp_release_fence(); \
> + __ret = cmpxchg_relaxed(ptr, o, n); \
> + __smp_acquire_fence(); \
> + __ret; \
> +})

So you failed to Cc me on patch #2 that introduces these barriers. I've
dug it out, but I'm still terribly confused on all that.

On first reading the above looks wrong.

Could you also clarify the difference (if any) between your bar.brwarw
and sync instruction?

Specifically, about transitiviry, or whatever we seem to be calling that
today.

\
 
 \ /
  Last update: 2021-01-07 14:11    [W:0.064 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site