Messages in this thread | | | Date | Thu, 7 Jan 2021 13:48:36 -0800 | From | Kees Cook <> | Subject | Re: [PATCH v4 mips-next 3/7] MIPS: properly stop .eh_frame generation |
| |
On Thu, Jan 07, 2021 at 12:35:01PM +0000, Alexander Lobakin wrote: > Commit 866b6a89c6d1 ("MIPS: Add DWARF unwinding to assembly") added > -fno-asynchronous-unwind-tables to KBUILD_CFLAGS to prevent compiler > from emitting .eh_frame symbols. > However, as MIPS heavily uses CFI, that's not enough. Use the > approach taken for x86 (as it also uses CFI) and explicitly put CFI > symbols into the .debug_frame section (except for VDSO). > This allows us to drop .eh_frame from DISCARDS as it's no longer > being generated. > > Fixes: 866b6a89c6d1 ("MIPS: Add DWARF unwinding to assembly") > Suggested-by: Kees Cook <keescook@chromium.org> > Signed-off-by: Alexander Lobakin <alobakin@pm.me>
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| |