Messages in this thread | | | Subject | Re: [PATCH v4 net-next 2/7] net: dsa: be louder when a non-legacy FDB operation fails | From | Florian Fainelli <> | Date | Wed, 6 Jan 2021 09:44:02 -0800 |
| |
On 1/6/21 1:51 AM, Vladimir Oltean wrote: > From: Vladimir Oltean <vladimir.oltean@nxp.com> > > The dev_close() call was added in commit c9eb3e0f8701 ("net: dsa: Add > support for learning FDB through notification") "to indicate inconsistent > situation" when we could not delete an FDB entry from the port. > > bridge fdb del d8:58:d7:00:ca:6d dev swp0 self master > > It is a bit drastic and at the same time not helpful if the above fails > to only print with netdev_dbg log level, but on the other hand to bring > the interface down. > > So increase the verbosity of the error message, and drop dev_close(). > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
| |