Messages in this thread | | | Date | Wed, 6 Jan 2021 15:43:24 +0100 | From | Jean Delvare <> | Subject | Re: [PATCH] i2c: remove h from printk format specifier |
| |
Hi Tom, Wolfram,
On Tue, 5 Jan 2021 11:09:42 +0100, Wolfram Sang wrote: > On Tue, Dec 15, 2020 at 10:33:27AM -0800, trix@redhat.com wrote: > > From: Tom Rix <trix@redhat.com> > > > > See Documentation/core-api/printk-formats.rst. > > h should no longer be used in the format specifier for printk. > > > > Signed-off-by: Tom Rix <trix@redhat.com> > > Adding Jean to CC. Jean, I'd think %02x would be better, what do you > think?
Agreed, 0x%02x would be better.
If this is done then you can add:
Reviewed-by: Jean Delvare <jdelvare@suse.de>
> > --- > > drivers/i2c/i2c-smbus.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/i2c/i2c-smbus.c b/drivers/i2c/i2c-smbus.c > > index d3d06e3b4f3b..5cd2cf84659e 100644 > > --- a/drivers/i2c/i2c-smbus.c > > +++ b/drivers/i2c/i2c-smbus.c > > @@ -396,7 +396,7 @@ void i2c_register_spd(struct i2c_adapter *adap) > > > > if (!IS_ERR(i2c_new_scanned_device(adap, &info, addr_list, NULL))) { > > dev_info(&adap->dev, > > - "Successfully instantiated SPD at 0x%hx\n", > > + "Successfully instantiated SPD at 0x%x\n", > > addr_list[0]); > > dimm_count--; > > }
-- Jean Delvare SUSE L3 Support
| |