lkml.org 
[lkml]   [2021]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] binfmt_elf: Fix fill_prstatus() call in fill_note_info()
On Wed, Jan 06, 2021 at 08:51:12AM +0100, Geert Uytterhoeven wrote:
> On m68k, which does not define CORE_DUMP_USE_REGSET:
>
> fs/binfmt_elf.c: In function ‘fill_note_info’:
> fs/binfmt_elf.c:2040:20: error: passing argument 1 of ‘fill_prstatus’ from incompatible pointer type [-Werror=incompatible-pointer-types]
> 2040 | fill_prstatus(info->prstatus, current, siginfo->si_signo);
> | ~~~~^~~~~~~~~~
> | |
> | struct elf_prstatus *
> fs/binfmt_elf.c:1498:55: note: expected ‘struct elf_prstatus_common *’ but argument is of type ‘struct elf_prstatus *’
> 1498 | static void fill_prstatus(struct elf_prstatus_common *prstatus,
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
>
> The fill_prstatus() signature was changed, but one caller was not
> updated.
>
> Reported-by: noreply@ellerman.id.au
> Fixes: 147d88b334cd5416 ("elf_prstatus: collect the common part (everything before pr_reg) into a struct")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Compile-tested only. Feel free to fold into the original commit.

Thanks, folded and pushed out...

\
 
 \ /
  Last update: 2021-01-06 14:47    [W:0.101 / U:0.484 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site