Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 6 Jan 2021 14:40:02 +0100 | Subject | Re: [PATCH -next] video: fbdev: pxa3xx_gcu: use resource_size |
| |
Hi Zheng,
On Wed, Jan 6, 2021 at 2:23 PM Zheng Yongjun <zhengyongjun3@huawei.com> wrote: > Use resource_size rather than a verbose computation on > the end and start fields. > > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Thanks for your patch!
But the one-line summary and patch description don't seem to match with the actual change?
> --- a/drivers/video/fbdev/pxa3xx-gcu.c > +++ b/drivers/video/fbdev/pxa3xx-gcu.c > @@ -594,8 +594,8 @@ static int pxa3xx_gcu_probe(struct platform_device *pdev) > * container_of(). This isn't really necessary as we have a fixed minor > * number anyway, but this is to avoid statics. */ > > - priv->misc_dev.minor = PXA3XX_GCU_MINOR, > - priv->misc_dev.name = DRV_NAME, > + priv->misc_dev.minor = PXA3XX_GCU_MINOR; > + priv->misc_dev.name = DRV_NAME; > priv->misc_dev.fops = &pxa3xx_gcu_miscdev_fops; > > /* handle IO resources */
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |