Messages in this thread | | | Subject | Re: [PATCH v2 1/2] dt-bindings: interrupt-controller: Add Realtek RTL838x/RTL839x support | From | Bert Vermeulen <> | Date | Wed, 6 Jan 2021 10:54:54 +0100 |
| |
On 1/5/21 6:04 PM, Rob Herring wrote: > On Mon, 04 Jan 2021 14:17:54 +0100, Bert Vermeulen wrote: >> Signed-off-by: Bert Vermeulen <bert@biot.com> >> --- >> .../realtek,rtl-intc.yaml | 57 +++++++++++++++++++ >> 1 file changed, 57 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/realtek,rtl-intc.yaml >> > > My bot found errors running 'make dt_binding_check' on your patch:
I fixed the syntax error that caused this to fail. But running the test now produces some errors that are not so obvious:
interrupt-controller@3000: interrupt-map: [[31, 4294967295, 2], [30, 4294967295, 1], [29, 4294967295, 5]] is too short
Not sure where this comes from, but running dt-validate -v gives this:
Failed validating 'minItems' in schema['properties']['interrupt-map']: {'maxItems': 24, 'minItems': 24}
Where did that 24 come from? I don't even have 24 initerrupts to map :-)
Another error is this:
interrupt-controller@3000: 'interrupt-map-mask' is a dependency of 'interrupt-map'
I can see this in your dtschema package's schemas/interrupt-controller.yaml where it's defined as a dependency, but why? I don't need that property.
-- Bert Vermeulen bert@biot.com
| |