Messages in this thread | | | Date | Wed, 6 Jan 2021 15:52:35 +0800 | From | Shuo A Liu <> | Subject | Re: [PATCH v6 04/18] x86/acrn: Introduce hypercall interfaces |
| |
On Wed 30.Dec'20 at 18:33:05 +0100, Borislav Petkov wrote: >On Tue, Dec 01, 2020 at 05:38:39PM +0800, shuo.a.liu@intel.com wrote: >> From: Shuo Liu <shuo.a.liu@intel.com> >> >> The Service VM communicates with the hypervisor via conventional >> hypercalls. VMCALL instruction is used to make the hypercalls. >> >> ACRN hypercall ABI: >> * Hypercall number is in R8 register. >> * Up to 2 parameters are in RDI and RSI registers. >> * Return value is in RAX register. >> >> Introduce the ACRN hypercall interfaces. Because GCC doesn't support R8 >> register as direct register constraints, use supported constraint as >> input with a explicit MOV to R8 in beginning of asm. >> >> Originally-by: Yakui Zhao <yakui.zhao@intel.com> >> Signed-off-by: Shuo Liu <shuo.a.liu@intel.com> >> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com> >> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> >> Cc: Dave Hansen <dave.hansen@intel.com> >> Cc: Sean Christopherson <sean.j.christopherson@intel.com> >> Cc: Dan Williams <dan.j.williams@intel.com> >> Cc: Fengwei Yin <fengwei.yin@intel.com> >> Cc: Zhi Wang <zhi.a.wang@intel.com> >> Cc: Zhenyu Wang <zhenyuw@linux.intel.com> >> Cc: Yu Wang <yu1.wang@intel.com> >> Cc: Reinette Chatre <reinette.chatre@intel.com> >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >> Cc: Borislav Petkov <bp@alien8.de> >> Cc: Arvind Sankar <nivedita@alum.mit.edu> >> Cc: Peter Zijlstra <peterz@infradead.org> >> Cc: Nick Desaulniers <ndesaulniers@google.com> >> Cc: Segher Boessenkool <segher@kernel.crashing.org> >> --- >> arch/x86/include/asm/acrn.h | 54 +++++++++++++++++++++++++++++++++++++ >> 1 file changed, 54 insertions(+) > >The x86 bits in patches 2-4 look ok now, thanks! > >Acked-by: Borislav Petkov <bp@suse.de>
Thanks for review!
Shuo
| |