lkml.org 
[lkml]   [2021]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] clocksource: ixp4xx: select TIMER_OF when needed
On Sun, Jan 3, 2021 at 3:00 PM Arnd Bergmann <arnd@kernel.org> wrote:

> From: Arnd Bergmann <arnd@arndb.de>
>
> Compile-testing the ixp4xx timer with CONFIG_OF enabled but
> CONFIG_TIMER_OF disabled leads to a harmless warning:
>
> arm-linux-gnueabi-ld: warning: orphan section `__timer_of_table' from `drivers/clocksource/timer-ixp4xx.o' being placed in section `__timer_of_table'
>
> Move the select statement from the platform code into the driver
> so it always gets enabled in configurations that rely on it.
>
> Fixes: 40df14cc5cc0 ("clocksource/drivers/ixp4xx: Add OF initialization support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

That's a nice fix!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2021-01-05 23:35    [W:0.052 / U:0.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site