Messages in this thread | | | From | Will Deacon <> | Subject | Re: [PATCH] iommu/amd: Set iommu->int_enabled consistently when interrupts are set up | Date | Tue, 5 Jan 2021 22:07:01 +0000 |
| |
On Tue, 05 Jan 2021 01:32:51 +0000, David Woodhouse wrote: > When I made the INTCAPXT support stop gratuitously pretending to be MSI, > I missed the fact that iommu_setup_msi() also sets the ->int_enabled > flag. I missed this in the iommu_setup_intcapxt() code path, which means > that a resume from suspend will try to allocate the IRQ domains again, > accidentally re-enabling interrupts as it does, resulting in much sadness. > > Lift out the bit which sets iommu->int_enabled into the iommu_init_irq() > function which is also where it gets checked.
Applied to arm64 (for-next/iommu/fixes), thanks!
[1/1] iommu/amd: Set iommu->int_enabled consistently when interrupts are set up https://git.kernel.org/arm64/c/12bc4570c14e
Cheers, -- Will
https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev
| |