lkml.org 
[lkml]   [2021]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 4/6] acpi/drivers/thermal: Remove TRIPS_NONE cooling device binding
    From
    Date
    Hi Rui,


    On 15/12/2020 00:38, Daniel Lezcano wrote:
    > The loop is here to create default cooling device binding on the
    > THERMAL_TRIPS_NONE number which is used to be the 'forced_passive'
    > feature. However, we removed all code dealing with that in the thermal
    > core, thus this binding does no longer make sense.
    >
    > Remove it.
    >
    > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

    Are you fine with this change?

    Thanks

    -- Daniel

    > ---
    > drivers/acpi/thermal.c | 19 -------------------
    > 1 file changed, 19 deletions(-)
    >
    > diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
    > index b5e4bc9e3282..26a89ff80a0e 100644
    > --- a/drivers/acpi/thermal.c
    > +++ b/drivers/acpi/thermal.c
    > @@ -764,25 +764,6 @@ static int acpi_thermal_cooling_device_cb(struct thermal_zone_device *thermal,
    > }
    > }
    >
    > - for (i = 0; i < tz->devices.count; i++) {
    > - handle = tz->devices.handles[i];
    > - status = acpi_bus_get_device(handle, &dev);
    > - if (ACPI_SUCCESS(status) && (dev == device)) {
    > - if (bind)
    > - result = thermal_zone_bind_cooling_device
    > - (thermal, THERMAL_TRIPS_NONE,
    > - cdev, THERMAL_NO_LIMIT,
    > - THERMAL_NO_LIMIT,
    > - THERMAL_WEIGHT_DEFAULT);
    > - else
    > - result = thermal_zone_unbind_cooling_device
    > - (thermal, THERMAL_TRIPS_NONE,
    > - cdev);
    > - if (result)
    > - goto failed;
    > - }
    > - }
    > -
    > failed:
    > return result;
    > }
    >


    --
    <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

    Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
    <http://twitter.com/#!/linaroorg> Twitter |
    <http://www.linaro.org/linaro-blog/> Blog

    \
     
     \ /
      Last update: 2021-01-05 16:46    [W:4.488 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site