lkml.org 
[lkml]   [2021]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 1/6] dt-bindings: PCI: Add bindings for Brcmstb EP voltage regulators
    On Tue, Jan 5, 2021 at 9:01 AM Mark Brown <broonie@kernel.org> wrote:
    >
    > On Mon, Jan 04, 2021 at 05:12:11PM -0500, Jim Quinlan wrote:
    >
    > > For us, the supplies are for the EP chip's power. We have the PCIe
    > > controller turning them "on" for power-on/resume and "off" for
    > > power-off/suspend. We need the "xxx-supply" property in the
    > > controller's DT node because of the chicken-and-egg situation: if the
    > > property was in the EP's DT node, the RC will never discover the EP
    > > to see that there is a regulator to turn on. We would be happy with
    > > a single supply name, something like "ep-power". We would be ecstatic
    > > to have two (ep0-power, ep1-power).
    >
    > Why can't the controller look at the nodes describing devices for
    > standard properties?
    Hi Mark,

    It just feels wrong for the driver (RC) of one DT node to be acting on
    a property of another driver's (EP) node, even though it is a subnode.
    There is also the possibility of the EP driver acting upon the
    property simultaneously; we don't really have control of what EP
    device and drivers are paired with our SOCs.
    In addition, this just pushes the binding name issue down a level --
    what should these power supplies be called? They are not slot power
    supplies. Can the Broadcom STB PCIe RC driver's binding document
    specify and define the properties of EP sub-nodes?

    Regards,
    Jim Quinlan
    Broadcom STB

    \
     
     \ /
      Last update: 2021-01-05 16:12    [W:2.551 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site