Messages in this thread | | | Date | Tue, 5 Jan 2021 14:15:36 +0000 | From | Mark Brown <> | Subject | Re: [PATCH v6 1/4] spi: LS7A: Add Loongson LS7A SPI controller driver support |
| |
On Mon, Dec 28, 2020 at 10:59:38AM +0800, Qing Zhang wrote:
> + if (!!(spi->mode & SPI_CS_HIGH) == enable) > + ls7a_spi_write_reg(ls7a_spi, SFC_SOFTCS, (0x1 << spi->chip_select) | cs); > + else > + ls7a_spi_write_reg(ls7a_spi, SFC_SOFTCS, (0x11 << spi->chip_select) | cs); > +}
The core will handle inverting the chip select for the driver when SIP_CS_HIGH so doing it again here will cause bugs. Just use the value of enable directly. Otherwise this looks good. [unhandled content-type:application/pgp-signature] | |