Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Tue, 5 Jan 2021 11:49:28 +0100 | Subject | Re: [PATCH 3/5] arm64: dts: renesas: Add I2C to R8A779A0 |
| |
Hi Wolfram,
On Wed, Dec 23, 2020 at 6:25 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > From: Koji Matsuoka <koji.matsuoka.xm@renesas.com> > > Add I2C devicetree description to V3U > > Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com> > [wsa: rebased and double checked] > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > @@ -14,6 +14,16 @@ / { > #address-cells = <2>; > #size-cells = <2>; > > + aliases { > + i2c0 = &i2c0; > + i2c1 = &i2c1; > + i2c2 = &i2c2; > + i2c3 = &i2c3; > + i2c4 = &i2c4; > + i2c5 = &i2c5; > + i2c6 = &i2c6; > + };
Do we need the i2c aliases? ;-)
> @@ -115,6 +125,118 @@ sysc: system-controller@e6180000 { > #power-domain-cells = <1>; > }; > > + i2c0: i2c@e6500000 { > + compatible = "renesas,i2c-r8a779a0", > + "renesas,rcar-gen3-i2c"; > + reg = <0 0xe6500000 0 0x40>; > + interrupts = <GIC_SPI 238 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 518>; > + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > + resets = <&cpg 518>; > + dmas = <&dmac1 0x91>, <&dmac1 0x90>; > + dma-names = "tx", "rx";
Might be wise to leave out the DMA properties until we have verified that DMA works?
> + i2c-scl-internal-delay-ns = <110>; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + };
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |