Messages in this thread | | | From | Daeho Jeong <> | Date | Wed, 6 Jan 2021 12:35:53 +0900 | Subject | Re: [f2fs-dev] [PATCH v2] f2fs: fix null page reference in redirty_blocks |
| |
Thanks for the notice~
2021년 1월 6일 (수) 오전 10:04, Chao Yu <yuchao0@huawei.com>님이 작성: > > Daeho, > > FYI > > https://www.spinics.net/lists/kernel/msg3595944.html > > On 2021/1/5 20:04, Markus Elfring wrote: > >> Fixed null page reference when find_lock_page() fails in > >> redirty_blocks(). > > > > I suggest to choose an other imperative wording for this change description. > > > > See also: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=36bbbd0e234d817938bdc52121a0f5473b3e58f5#n89 > > > > > >> v2: changed error value and break the loop when error occurs > > > > I propose to use a return statement instead of a break in the second if branch > > for this function implementation. > > > > See also: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=36bbbd0e234d817938bdc52121a0f5473b3e58f5#n481 > > > > Regards, > > Markus > > > > > > _______________________________________________ > > Linux-f2fs-devel mailing list > > Linux-f2fs-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > > . > > > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
| |