Messages in this thread | | | Subject | Re: [PATCH] [v2] iommu/intel: Fix memleak in intel_irq_remapping_alloc | From | Lu Baolu <> | Date | Tue, 5 Jan 2021 16:38:04 +0800 |
| |
On 2021/1/5 13:18, Dinghao Liu wrote: > When irq_domain_get_irq_data() or irqd_cfg() fails > at i == 0, data allocated by kzalloc() has not been > freed before returning, which leads to memleak. > > Fixes: b106ee63abccb ("irq_remapping/vt-d: Enhance Intel IR driver to support hierarchical irqdomains") > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Acked-by: Lu Baolu <baolu.lu@linux.intel.com>
Best regards, baolu
> --- > > Changelog: > > v2: - Add a check against i instead of setting data to NULL. > --- > drivers/iommu/intel/irq_remapping.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/iommu/intel/irq_remapping.c b/drivers/iommu/intel/irq_remapping.c > index aeffda92b10b..685200a5cff0 100644 > --- a/drivers/iommu/intel/irq_remapping.c > +++ b/drivers/iommu/intel/irq_remapping.c > @@ -1353,6 +1353,8 @@ static int intel_irq_remapping_alloc(struct irq_domain *domain, > irq_data = irq_domain_get_irq_data(domain, virq + i); > irq_cfg = irqd_cfg(irq_data); > if (!irq_data || !irq_cfg) { > + if (!i) > + kfree(data); > ret = -EINVAL; > goto out_free_data; > } >
| |