lkml.org 
[lkml]   [2021]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 net RESEND] net/sonic: Fix some resource leaks in error handling paths
From
From: Finn Thain <fthain@telegraphics.com.au>
Date: Sun, 03 Jan 2021 11:26:26 +1100

> From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>
> A call to dma_alloc_coherent() is wrapped by sonic_alloc_descriptors().
>
> This is correctly freed in the remove function, but not in the error
> handling path of the probe function. Fix this by adding the missing
> dma_free_coherent() call.
>
> While at it, rename a label in order to be slightly more informative.
>
> Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: Chris Zankel <chris@zankel.net>
> References: commit 10e3cc180e64 ("net/sonic: Fix a resource leak in an error handling path in 'jazz_sonic_probe()'")
> Fixes: 74f2a5f0ef64 ("xtensa: Add support for the Sonic Ethernet device for the XT2000 board.")
> Fixes: efcce839360f ("[PATCH] macsonic/jazzsonic network drivers update")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>

Applied and queued up for -stable, thanks.

\
 
 \ /
  Last update: 2021-01-06 01:01    [W:0.031 / U:0.864 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site