Messages in this thread | | | Date | Tue, 05 Jan 2021 15:58:06 -0800 (PST) | Subject | Re: [PATCH] liquidio: style: Identical condition and return expression 'retval', return value is always 0. | From | David Miller <> |
| |
From: YANG LI <abaci-bugfix@linux.alibaba.com> Date: Wed, 30 Dec 2020 14:07:30 +0800
> The warning was because of the following line in function > liquidio_set_fec(): > > retval = wait_for_sc_completion_timeout(oct, sc, 0); > if (retval) > return (-EIO); > > If this statement is not true, retval must be 0 and not updated > later. So, It is better to return 0 directly. > > Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com> > Reported-by: Abaci <abaci@linux.alibaba.com>
Maybe you can remove the rest of the 'retval' usage in this function and even the variable itself?
Thanks.
| |