lkml.org 
[lkml]   [2021]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sound: Convert strlcpy to strscpy when return value is unused
On Thu, 31 Dec 2020 20:04:50 +0100,
Joe Perches wrote:
>
> strlcpy is deprecated. see: Documentation/process/deprecated.rst
>
> Change the calls that do not use the strlcpy return value to the
> preferred strscpy.
>
> Done with cocci script:
>
> @@
> expression e1, e2, e3;
> @@
>
> - strlcpy(
> + strscpy(
> e1, e2, e3);
>
> This cocci script leaves the instances where the return value is
> used unchanged.
>
> After this patch, sound/ has 3 uses of strlcpy() that need to be
> manually inspected for conversion and changed one day.
>
> $ git grep -w strlcpy sound/
> sound/usb/card.c: len = strlcpy(card->longname, s, sizeof(card->longname));
> sound/usb/mixer.c: return strlcpy(buf, p->name, buflen);
> sound/usb/mixer.c: return strlcpy(buf, p->names[index], buflen);
>
> Miscellenea:
>
> o Remove trailing whitespace in conversion of sound/core/hwdep.c
>
> Link: https://lore.kernel.org/lkml/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
>
> Signed-off-by: Joe Perches <joe@perches.com>

Could you resubmit to alsa-devel ML?


thanks,

Takashi

\
 
 \ /
  Last update: 2021-01-04 18:03    [W:0.039 / U:1.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site