Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Mon, 4 Jan 2021 15:17:46 +0100 | Subject | Re: [RFC PATCH 2/3] gpio: ep93xx: drop to_irq binding |
| |
On Sun, Dec 27, 2020 at 10:21 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Thu, Dec 24, 2020 at 12:22 PM Nikita Shubin > <nikita.shubin@maquefel.me> wrote: > > > As ->to_irq is redefined in gpiochip_add_irqchip, having it defined in > > driver is useless, so let's drop it. > > > > Also i think it is worth to give a gentle warning in > > gpiochip_add_irqchip, to prevent people relying on to_irq. > > > > For example > > > > WARN_ON_ONCE(gc->to_irq, > > "to_irq is redefined in gpiochip_add_irqchip" \ > > "and you shouldn't rely on it\n"); > > > > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > Take out the suggestion in the commit message and implement it, > but I think WARN_ON is too nasty, just use dev_err(). > > Yours, > Linus Walleij
This depends on patch 1/3 so I'll wait until you resend with issues addressed.
Bartosz
| |