Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 4 Jan 2021 12:05:21 +0100 | Subject | Re: [PATCH] gpio: Kconfig: Update help description for GPIO_RCAR |
| |
Hi Bartosz et al,
On Sun, Jan 3, 2021 at 4:29 PM Bartosz Golaszewski <bgolaszewski@baylibre.com> wrote: > On Fri, Jan 1, 2021 at 6:07 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > > > -----Original Message----- > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > Sent: 31 December 2020 15:39 > > > To: Linus Walleij <linus.walleij@linaro.org>; Bartosz Golaszewski > > > <bgolaszewski@baylibre.com>; Geert Uytterhoeven <geert+renesas@glider.be> > > > Cc: linux-gpio@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > > > renesas-soc@vger.kernel.org; Prabhakar <prabhakar.csengg@gmail.com>; > > > Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > Subject: [PATCH] gpio: Kconfig: Update help description for GPIO_RCAR > > > > > > The gpio-rcar driver supports R-Car Gen{1,2,3} and RZ/G{1,2} SoC's, update > > > the description to reflect this. > > > > Not sure we need to make this generic by dropping {1,2,3}/{1,2} and use R-Car and RZ/G SoC's instead ??? > > > > This looks better IMO - if Geert is OK with that, then let's change it.
"R-Car and RZ/G" sounds better to me, as it is present on all known R-Car and RZ/G SoCs. We can change the help text if that ever changes.
> > > --- a/drivers/gpio/Kconfig > > > +++ b/drivers/gpio/Kconfig > > > @@ -486,11 +486,12 @@ config GPIO_PXA > > > Say yes here to support the PXA GPIO device > > > > > > config GPIO_RCAR > > > - tristate "Renesas R-Car GPIO" > > > + tristate "Renesas R-Car Gen{1,2,3} and RZ/G{1,2} GPIO support" > > > depends on ARCH_RENESAS || COMPILE_TEST > > > select GPIOLIB_IRQCHIP > > > help > > > - Say yes here to support GPIO on Renesas R-Car SoCs. > > > + Say yes here to support GPIO on Renesas R-Car Gen{1,2,3} and > > > + RZ/G{1,2} SoCs. > > > > > > config GPIO_RDA > > > bool "RDA Micro GPIO controller support"
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |