lkml.org 
[lkml]   [2021]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] USB: serial: option: add LongSung M5710 module support
On Sun, Dec 27, 2020 at 12:17:16PM +0900, Daniel Palmer wrote:
> Add a vendor id for LongSung and a product id for the M5710 module.
>
> Signed-off-by: Daniel Palmer <daniel@0x0f.com>
> ---
> drivers/usb/serial/option.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 2c21e34235bb..2666e061c38d 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -560,6 +560,9 @@ static void option_instat_callback(struct urb *urb);
> #define WETELECOM_PRODUCT_6802 0x6802
> #define WETELECOM_PRODUCT_WMD300 0x6803
>
> +/* LongSung */
> +#define LONGSUNG_VENDOR_ID 0x2df3
> +#define LONGSUNG_PRODUCT_M5710 0x9d03

I'm trying to move away from adding such defines for new devices as they
do not really add any value so I dropped them from the patch.

> /* Device flags */
>
> @@ -2060,6 +2063,8 @@ static const struct usb_device_id option_ids[] = {
> { USB_DEVICE_INTERFACE_CLASS(0x305a, 0x1404, 0xff) }, /* GosunCn GM500 RNDIS */
> { USB_DEVICE_INTERFACE_CLASS(0x305a, 0x1405, 0xff) }, /* GosunCn GM500 MBIM */
> { USB_DEVICE_INTERFACE_CLASS(0x305a, 0x1406, 0xff) }, /* GosunCn GM500 ECM/NCM */
> + /* LongSung devices */
> + { USB_DEVICE(LONGSUNG_VENDOR_ID, LONGSUNG_PRODUCT_M5710) }, /* LongSung M5710 */
> { } /* Terminating entry */
> };
> MODULE_DEVICE_TABLE(usb, option_ids);

Also, would you mind posting the "lsusb -v" output for this device for
reference? Do you know what each interface is used for?

I've applied this one locally, but I'll await your reply before pushing
it out.

Johan

\
 
 \ /
  Last update: 2021-01-04 11:35    [W:0.064 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site