lkml.org 
[lkml]   [2021]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] x86/compat: Pull huge_encode_dev() outside of UACCESS
From
Date
On 1/4/21 3:14 PM, Josh Poimboeuf wrote:
> On Mon, Jan 04, 2021 at 11:24:23AM -0600, Josh Poimboeuf wrote:
>> On Mon, Jan 04, 2021 at 04:53:47PM +0100, Peter Zijlstra wrote:
>>> On Mon, Jan 04, 2021 at 09:31:27AM -0600, Josh Poimboeuf wrote:
>>>> Peter, care to submit a proper patch?
>>>
>>> Here goes..
>>>
>>> ---
>>> Subject: x86/compat: Pull huge_encode_dev() outside of UACCESS
>>> From: Peter Zijlstra <peterz@infradead.org>
>>> Date: Mon, 4 Jan 2021 13:28:25 +0100
>>>
>>> Fixes the following warning:
>>>
>>> arch/x86/kernel/sys_ia32.o: warning: objtool: cp_stat64()+0xd8: call to new_encode_dev() with UACCESS enabled
>>>
>>> Reported-by: Randy Dunlap <rdunlap@infradead.org>
>>> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
>>
>> Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
>
> Actually the other patch was already merged into Linus' tree.
>
> Maybe add a revert of the other patch to this one?
>

Glad you noticed.

I reverted the kdev_t patch and applied Peter's patch and it
still tested OK, so (still):

Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

--
~Randy

\
 
 \ /
  Last update: 2021-01-05 00:58    [W:0.036 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site