Messages in this thread | | | Date | Sun, 31 Jan 2021 06:24:33 -0500 | From | Brian Masney <> | Subject | Re: [PATCH] soc: qcom: ocmem: don't return NULL in of_get_ocmem |
| |
On Sat, Jan 30, 2021 at 03:23:49PM +0100, Luca Weiss wrote: > If ocmem probe fails for whatever reason, of_get_ocmem returned NULL. > Without this, users must check for both NULL and IS_ERR on the returned > pointer - which didn't happen in drivers/gpu/drm/msm/adreno/adreno_gpu.c > leading to a NULL pointer dereference. > > Fixes: 88c1e9404f1d ("soc: qcom: add OCMEM driver") > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
Reviewed-by: Brian Masney <masneyb@onstation.org>
| |