Messages in this thread | | | Subject | Re: [PATCH] powerpc: fix AKEBONO build failures | From | Randy Dunlap <> | Date | Sat, 30 Jan 2021 15:21:55 -0800 |
| |
On 1/21/21 5:14 PM, Michael Ellerman wrote: > Randy Dunlap <rdunlap@infradead.org> writes: >> On 1/20/21 1:29 PM, Yury Norov wrote: >>> Hi all, >>> >>> I found the power pc build broken on today's >>> linux-next (647060f3b592). >> >> Darn, I was building linux-5.11-rc4. >> >> I'll try linux-next after I send this. >> >> --- >> From: Randy Dunlap <rdunlap@infradead.org> >> >> Fulfill AKEBONO Kconfig requirements. >> >> Fixes these Kconfig warnings (and more) and fixes the subsequent >> build errors: >> >> WARNING: unmet direct dependencies detected for NETDEVICES >> Depends on [n]: NET [=n] >> Selected by [y]: >> - AKEBONO [=y] && PPC_47x [=y] >> >> WARNING: unmet direct dependencies detected for MMC_SDHCI >> Depends on [n]: MMC [=n] && HAS_DMA [=y] >> Selected by [y]: >> - AKEBONO [=y] && PPC_47x [=y] >> >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >> Cc: Michael Ellerman <mpe@ellerman.id.au> >> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> >> Cc: Paul Mackerras <paulus@samba.org> >> Cc: linuxppc-dev@lists.ozlabs.org >> Cc: Yury Norov <yury.norov@gmail.com> >> --- >> arch/powerpc/platforms/44x/Kconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> --- lnx-511-rc4.orig/arch/powerpc/platforms/44x/Kconfig >> +++ lnx-511-rc4/arch/powerpc/platforms/44x/Kconfig >> @@ -206,6 +206,7 @@ config AKEBONO >> select PPC4xx_HSTA_MSI >> select I2C >> select I2C_IBM_IIC >> + select NET >> select NETDEVICES >> select ETHERNET >> select NET_VENDOR_IBM > > I think the problem here is too much use of select, for things that > should instead be in the defconfig. > > The patch below results in the same result for make > 44x/akebono_defconfig. Does it fix the original issue?
Hi Michael, Sorry for the delay.
Changing the akebono_defconfig doesn't cause the missing symbols to be set -- the defconfig is not being used here.
I guess that if you have users who set CONFIG_AKEBONO and expect it to build cleanly, you will need something like my patch or the patch that Florian just posted.
Changing the akebono_defconfig also would not help 'make randconfig' builds to build cleanly if they had happened to enable AKEBONO.
> We don't need to add ETHERNET or NET_VENDOR_IBM to the defconfig because > they're both default y. > > cheers
| |