lkml.org 
[lkml]   [2021]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V2 19/19] vdpa: introduce virtio pci driver
From
Date

On 2020/12/4 下午11:20, Stefano Garzarella wrote:
>> +#define VP_VDPA_QUEUE_MAX 256
>> +#define VP_VDPA_DRIVER_NAME "vp_vdpa"
>> +
>> +struct vp_vring {
>> +    void __iomem *notify;
>> +    char msix_name[256];
>
> Can we use a macro for the msix_name size, since we use 256 in
> multiple places?


Yes, will switch to use a macro.


>
>> +    struct vdpa_callback cb;
>> +    int irq;
>> +};
>> +
>> +struct vp_vdpa {
>> +    struct vdpa_device vdpa;
>> +    struct virtio_pci_modern_device mdev;
>> +    struct vp_vring *vring;
>> +    struct vdpa_callback cb;
>                              ^
> It is not relevant, but 'config_cb' is maybe clearer to read.
>

Will change to config_cb.


> The rest looks good.


Thanks


>
> Thanks,
> Stefano

\
 
 \ /
  Last update: 2021-01-04 04:34    [W:0.158 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site