lkml.org 
[lkml]   [2021]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 01/15] software_node: Fix refcounts in software_node_get_next_child()
    Date
    The software_node_get_next_child() function currently does not hold
    references to the child software_node that it finds or put the ref that
    is held against the old child - fix that.

    Fixes: 59abd83672f7 ("drivers: base: Introducing software nodes to the firmware node framework")
    Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
    Signed-off-by: Daniel Scally <djrscally@gmail.com>
    ---
    Changes in v4:

    - None

    drivers/base/swnode.c | 8 ++++++--
    1 file changed, 6 insertions(+), 2 deletions(-)

    diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c
    index 010828fc785b..615a0c93e116 100644
    --- a/drivers/base/swnode.c
    +++ b/drivers/base/swnode.c
    @@ -443,14 +443,18 @@ software_node_get_next_child(const struct fwnode_handle *fwnode,
    struct swnode *c = to_swnode(child);

    if (!p || list_empty(&p->children) ||
    - (c && list_is_last(&c->entry, &p->children)))
    + (c && list_is_last(&c->entry, &p->children))) {
    + fwnode_handle_put(child);
    return NULL;
    + }

    if (c)
    c = list_next_entry(c, entry);
    else
    c = list_first_entry(&p->children, struct swnode, entry);
    - return &c->fwnode;
    +
    + fwnode_handle_put(child);
    + return fwnode_handle_get(&c->fwnode);
    }

    static struct fwnode_handle *
    --
    2.25.1
    \
     
     \ /
      Last update: 2021-01-04 00:16    [W:3.073 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site