Messages in this thread | | | Subject | Re: [PATCH] PCI: endpoint: Select configfs dependency | From | Kishon Vijay Abraham I <> | Date | Fri, 29 Jan 2021 13:47:35 +0530 |
| |
Hi Arnd, Lorenzo,
On 25/01/21 5:04 pm, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The newly added pci-epf-ntb driver uses configfs, which > causes a link failure when that is disabled at compile-time: > > arm-linux-gnueabi-ld: drivers/pci/endpoint/functions/pci-epf-ntb.o: in function `epf_ntb_add_cfs': > pci-epf-ntb.c:(.text+0x954): undefined reference to `config_group_init_type_name' > > Add a 'select' statement to Kconfig to ensure it's always there, > which is the common way to enable it for other configfs users. > > Fixes: 7dc64244f9e9 ("PCI: endpoint: Add EP function driver to provide NTB functionality") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Since I'm sending a new revision of NTB driver, I'll squash this patch with the driver patch and add Arnd's sign off.
Thank You, Kishon
> --- > drivers/pci/endpoint/functions/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/endpoint/functions/Kconfig b/drivers/pci/endpoint/functions/Kconfig > index 24bfb2af65a1..5d35fcd613ef 100644 > --- a/drivers/pci/endpoint/functions/Kconfig > +++ b/drivers/pci/endpoint/functions/Kconfig > @@ -16,6 +16,7 @@ config PCI_EPF_TEST > config PCI_EPF_NTB > tristate "PCI Endpoint NTB driver" > depends on PCI_ENDPOINT > + select CONFIGFS_FS > help > Select this configuration option to enable the NTB driver > for PCI Endpoint. NTB driver implements NTB controller >
| |