lkml.org 
[lkml]   [2021]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 03/13] livepatch: refactor klp_init_object
    On Thu, Jan 28, 2021 at 05:22:40PM +0100, Christoph Hellwig wrote:
    > > We need to either update the function description or keep this check.
    > >
    > > I prefer to keep the check. The function does the right thing also
    > > for the object "vmlinux". Also the livepatch code includes many
    > > similar paranoid checks that makes the code less error prone
    > > against any further changes.
    >
    > Well, the check is in the caller now where we have a conditional for
    > it. So I'd be tempted to either update the comment, or just drop the
    > patch.

    Also even without the check I think it will do the right thing when
    called for vmlinux given that it simplify won't find a module called
    vmlinux..

    \
     
     \ /
      Last update: 2021-01-28 17:26    [W:2.457 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site