Messages in this thread | | | From | Arnd Bergmann <> | Date | Thu, 28 Jan 2021 15:28:00 +0100 | Subject | Re: [PATCH v5 2/4] ARM: hisi: add support for Kunpeng50x SoC |
| |
On Sat, Jan 16, 2021 at 4:32 AM Zhen Lei <thunder.leizhen@huawei.com> wrote: > > Enable support for the Hisilicon Kunpeng506 and Kunpeng509 SoC. > > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > --- > arch/arm/mach-hisi/Kconfig | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/mach-hisi/Kconfig b/arch/arm/mach-hisi/Kconfig > index 2e980f834a6aa1b..c724acc5c642b97 100644 > --- a/arch/arm/mach-hisi/Kconfig > +++ b/arch/arm/mach-hisi/Kconfig > @@ -55,6 +55,14 @@ config ARCH_HIX5HD2 > help > Support for Hisilicon HIX5HD2 SoC family > > +config ARCH_KUNPENG50X > + bool "Hisilicon Kunpeng50x family" > + depends on ARCH_MULTI_V7 > + select ARCH_FLATMEM_ENABLE > + select ARCH_HAS_HOLES_MEMORYMODEL if SPARSEMEM
I think the two 'select' statements are both wrong, though for different reasons:
- ARCH_FLATMEM_ENABLE is already selected by ARCH_MULTIPLATFORM, and is something that should not be platform specific
- ARCH_HAS_HOLES_MEMORYMODEL was removed in v5.11, and should also not be selected by a platform.
Otherwise, this seems fine.
Arnd
| |