lkml.org 
[lkml]   [2021]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] PCI/ASPM: Disable ASPM when save/restore PCI state
Hi Victor,

Thank you for working on this!

[...]
> i = pci_save_pcie_state(dev);
> if (i != 0)
> - return i;
> + goto Exit;
>
> i = pci_save_pcix_state(dev);
> if (i != 0)
> - return i;
> + goto Exit;
[...]
> +Exit:
> + pcie_restore_aspm_control(dev);
> + return i;
> }
[...]

A silly thing, but the goto labels are customary lower-case.

Nonetheless, this is probably something that can be corrected when
applying, so that you don't need to unnecessarily send a new version
(unless you will eventually following other reviews, then don't forget
about it).

Krzysztof

\
 
 \ /
  Last update: 2021-01-28 14:48    [W:0.092 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site