lkml.org 
[lkml]   [2021]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [RFC PATCH 29/34] power/swap: use bio_new in hib_submit_io
    On Thu, Jan 28, 2021 at 8:21 AM Chaitanya Kulkarni
    <chaitanya.kulkarni@wdc.com> wrote:
    >

    Please explain in the changelog why making this change is a good idea.

    > Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
    > ---
    > kernel/power/swap.c | 7 +++----
    > 1 file changed, 3 insertions(+), 4 deletions(-)
    >
    > diff --git a/kernel/power/swap.c b/kernel/power/swap.c
    > index c73f2e295167..e92e36c053a6 100644
    > --- a/kernel/power/swap.c
    > +++ b/kernel/power/swap.c
    > @@ -271,13 +271,12 @@ static int hib_submit_io(int op, int op_flags, pgoff_t page_off, void *addr,
    > struct hib_bio_batch *hb)
    > {
    > struct page *page = virt_to_page(addr);
    > + sector_t sect = page_off * (PAGE_SIZE >> 9);
    > struct bio *bio;
    > int error = 0;
    >
    > - bio = bio_alloc(GFP_NOIO | __GFP_HIGH, 1);
    > - bio->bi_iter.bi_sector = page_off * (PAGE_SIZE >> 9);
    > - bio_set_dev(bio, hib_resume_bdev);
    > - bio_set_op_attrs(bio, op, op_flags);
    > + bio = bio_new(hib_resume_bdev, sect, op, op_flags, 1,
    > + GFP_NOIO | __GFP_HIGH);
    >
    > if (bio_add_page(bio, page, PAGE_SIZE, 0) < PAGE_SIZE) {
    > pr_err("Adding page to bio failed at %llu\n",
    > --
    > 2.22.1
    >

    \
     
     \ /
      Last update: 2021-01-28 11:23    [W:4.989 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site