lkml.org 
[lkml]   [2021]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v4 1/2] dt-bindings: counter: add pulse-counter binding
Hi Oleksij,

thanks for your patch!

On Tue, Jan 26, 2021 at 2:15 PM Oleksij Rempel <o.rempel@pengutronix.de> wrote:

> Add binding for the pulse counter node
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
(...)

> +properties:
> + compatible:
> + const: virtual,pulse-counter

What is so virtual about this? The device seems very real.
However it is certainly a GPIO counter.

I would call it "gpio-counter" simply.

Define:
$nodename:
pattern: "^counter(@.*)?$"

> + counter-0 {

counter@0 {

> + counter-1 {

counter@1 {

Thanks!
Linus Walleij

\
 
 \ /
  Last update: 2021-01-28 09:20    [W:0.077 / U:2.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site