lkml.org 
[lkml]   [2021]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 04/13] module: use RCU to synchronize find_module
Date

Hi Christoph,

Christoph Hellwig <hch@lst.de> writes:

> diff --git a/kernel/module.c b/kernel/module.c
> index 981302f616b411..6772fb2680eb3e 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -668,7 +668,6 @@ static struct module *find_module_all(const char *name, size_t len,
>
> struct module *find_module(const char *name)
> {
> - module_assert_mutex();

Does it make sense to replace the assert above with the warn below (untested)?

RCU_LOCKDEP_WARN(rcu_read_lock_sched_held());

> return find_module_all(name, strlen(name), false);
> }

--
Thiago Jung Bauermann
IBM Linux Technology Center

\
 
 \ /
  Last update: 2021-01-28 21:53    [W:0.186 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site