Messages in this thread | | | Subject | Re: [PATCH 3/3] media: vidtv: add initial debugfs interface | From | Daniel Almeida <> | Date | Wed, 27 Jan 2021 09:26:52 -0300 |
| |
Hi Mauro! Thanks for the review.
Just one more thing though: what did you think about the way I chose to inject the errors? (e.g. drop packet, shift bytes, create discontinuity...etc etc)
I was just trying out a few ideas in this patch so if you also have any input on this please let me know.
As of now writing to any of these files will cause a myriad of errors on dvbinspector.
>> + >> +#. dynamically inject errors at runtime by interacting with the files at /sys/kernel/debug/vidtv/* >> + >> +#. read some dvbv5 statistics from userspace more easily >> + >> +.. note:: >> + This is entirely optional and the driver will work without this option selected. > Please keep lines <= 80 columns, except when there's a strong reason to > use longer lines. The same applies to other parts of this patch. > I was under the assumption that this had been bumped to 100 recently.
-- thanks
-- Daniel
| |