lkml.org 
[lkml]   [2021]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 03/10] mm: don't pass "enum lru_list" to lru list addition functions
    From
    Date
    On 1/26/21 10:34 PM, Yu Zhao wrote:
    > On Tue, Jan 26, 2021 at 08:13:11PM +0100, Vlastimil Babka wrote:
    >> On 1/22/21 11:05 PM, Yu Zhao wrote:
    >> > The "enum lru_list" parameter to add_page_to_lru_list() and
    >> > add_page_to_lru_list_tail() is redundant in the sense that it can
    >> > be extracted from the "struct page" parameter by page_lru().
    >>
    >> Okay, however, it means repeated extraction of a value that we already knew. The
    >> result of compilation is rather sad. This is bloat-o-meter on mm/built-in.a
    >> (without CONFIG_DEBUG_VM, btw) between patch 2 and 5:
    >
    > Thanks for noticing this, Vlastimil. Should I drop the rest of the
    > series except the first patch?

    I didn't check how 6-10 look (and if they are still applicable without 3-5),
    this was just between 2 and 5.

    \
     
     \ /
      Last update: 2021-01-27 11:56    [W:3.342 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site