Messages in this thread | | | Date | Wed, 27 Jan 2021 11:45:01 +0100 (CET) | From | Miroslav Benes <> | Subject | Re: [PATCH] stacktrace: Move documentation for arch_stack_walk_reliable() to header |
| |
On Mon, 18 Jan 2021, Mark Brown wrote:
> Currently arch_stack_wallk_reliable() is documented with an identical > comment in both x86 and S/390 implementations which is a bit redundant. > Move this to the header and convert to kerneldoc while we're at it.
Makes sense.
> Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Borislav Petkov <bp@alien8.de> > Cc: "H. Peter Anvin" <hpa@zytor.com> > Cc: Heiko Carstens <hca@linux.ibm.com> > Cc: Vasily Gorbik <gor@linux.ibm.com> > Cc: Christian Borntraeger <borntraeger@de.ibm.com> > Cc: Josh Poimboeuf <jpoimboe@redhat.com> > Cc: Jiri Kosina <jikos@kernel.org> > Cc: Miroslav Benes <mbenes@suse.cz> > Cc: Petr Mladek <pmladek@suse.com> > Cc: Joe Lawrence <joe.lawrence@redhat.com> > Cc: x86@kernel.org > Cc: linux-s390@vger.kernel.org > Cc: live-patching@vger.kernel.org > Signed-off-by: Mark Brown <broonie@kernel.org>
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
> diff --git a/arch/s390/kernel/stacktrace.c b/arch/s390/kernel/stacktrace.c > index 7f1266c24f6b..101477b3e263 100644 > --- a/arch/s390/kernel/stacktrace.c > +++ b/arch/s390/kernel/stacktrace.c > @@ -24,12 +24,6 @@ void arch_stack_walk(stack_trace_consume_fn consume_entry, void *cookie, > } > } > > -/* > - * This function returns an error if it detects any unreliable features of the > - * stack. Otherwise it guarantees that the stack trace is reliable. > - * > - * If the task is not 'current', the caller *must* ensure the task is inactive. > - */ > int arch_stack_walk_reliable(stack_trace_consume_fn consume_entry, > void *cookie, struct task_struct *task) > {
Just a note. arch/powerpc/kernel/stacktrace.c has the same for __save_stack_trace_tsk_reliable(), but it would not be nice to pollute include/linux/stacktrace.h with that in my opinion. It is an old infrastructure after all.
Miroslav
| |