Messages in this thread | | | Date | Wed, 27 Jan 2021 15:59:36 +0800 | From | Can Guo <> | Subject | Re: [RFC PATCH v1 1/2] block: bsg: resume scsi device before accessing |
| |
On 2021-01-27 15:09, Avri Altman wrote: >> >> Resumes the scsi device before accessing it. >> >> Change-Id: I2929af60f2a92c89704a582fcdb285d35b429fde >> Signed-off-by: Asutosh Das <asutoshd@codeaurora.org> >> Signed-off-by: Can Guo <cang@codeaurora.org> >> Signed-off-by: Bao D. Nguyen <nguyenb@codeaurora.org> > Following this patch, is it possible to revert commit 74e5e468b664d? >
No, but this is a good finding... This change assumes that the queue->queue_data is a scsi_device, which is why we call scsi_auto_pm_get(). But for ufs_bsg's case, queue->queue_data is a device...
Thanks, Can Guo.
> Thanks, > Avri
| |