lkml.org 
[lkml]   [2021]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2] mtip32xx: use PCI #defines instead of numbers
Date


> On Jan 26, 2021, at 11:41 PM, Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com> wrote:
>
> On 1/26/21 14:14, Bjorn Helgaas wrote:
>> From: Bjorn Helgaas <bhelgaas@google.com>
>>
>> Use PCI #defines for PCIe Device Control register values instead of
>> hard-coding bit positions. No functional change intended.
>>
>> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>
> I've verified the values present in the include/uapi/linux/pci_regs.h
> matches open coded bit shift values. LGTM.
>
> Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
>
Something is seriously wrong. I sent out this in the morning and it got delivered right now.
>
\
 
 \ /
  Last update: 2021-01-27 09:15    [W:0.051 / U:0.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site