lkml.org 
[lkml]   [2021]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v8] perf stat: Fix wrong skipping for per-die aggregation
From
Date
Hi Jiri,

On 1/28/2021 6:08 AM, Jiri Olsa wrote:
>> @@ -1385,7 +1386,8 @@ void evsel__exit(struct evsel *evsel)
>> zfree(&evsel->group_name);
>> zfree(&evsel->name);
>> zfree(&evsel->pmu_name);
>> - zfree(&evsel->per_pkg_mask);
> sorry I did not notice before, but I think we need to call
> zero_per_pkg in here, otherwise we're leaking keys
>
> jirka
>

Sorry, I forgot to add the release code here. :(

I will rename zero_per_pkg to evsel__zero_per_pkg and move it to evsel.c and call
evsel__zero_per_pkg in evsel__exit().

Thanks
Jin Yao


\
 
 \ /
  Last update: 2021-01-28 02:29    [W:0.044 / U:27.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site