Messages in this thread | | | Subject | Re: [PATCH v3 2/3] x509: Add support for parsing x509 certs with NIST p256 keys | From | Stefan Berger <> | Date | Wed, 27 Jan 2021 17:39:06 -0500 |
| |
On 1/27/21 2:31 PM, Herbert Xu wrote: > On Wed, Jan 27, 2021 at 07:33:49AM -0500, Stefan Berger wrote: >> +static struct akcipher_alg ecc_nist_p256 = { >> + .verify = ecdsa_verify, >> + .set_pub_key = ecc_set_pub_key, >> + .max_size = ecc_nist_p256_max_size, >> + .init = ecc_nist_p256_init_tfm, >> + .exit = ecc_exit_tfm, >> + .base = { >> + .cra_name = "nist_p256", >> + .cra_driver_name = "ecc-nist-p256", >> + .cra_priority = 100, >> + .cra_module = THIS_MODULE, >> + .cra_ctxsize = sizeof(struct ecc_ctx), >> + }, >> +}; > This is not how we name generic algorithms.
Are saying that I cannot name it "nist_p256" but should call it 'ecdsa' and the driver becomes "ecdsa-generic"?
> > Please split this out and submit them through the crypto tree > instead.
Will do.
> > Thanks,
| |