Messages in this thread | | | From | Linus Walleij <> | Date | Wed, 27 Jan 2021 22:46:37 +0100 | Subject | Re: [PATCH V2 1/1] net: dsa: rtl8366rb: standardize init jam tables |
| |
On Wed, Jan 27, 2021 at 2:07 AM Lorenzo Carletti <lorenzo.carletti98@gmail.com> wrote:
> In the rtl8366rb driver there are some jam tables which contain > undocumented values. > While trying to understand what these tables actually do, > I noticed a discrepancy in how one of those was treated. > Most of them were plain u16 arrays, while the ethernet one was > an u16 matrix. > By looking at the vendor's droplets of source code these tables came from, > I found out that they were all originally u16 matrixes. > > This commit standardizes the jam tables, turning them all into > jam_tbl_entry arrays. Each entry contains 2 u16 values. > This change makes it easier to understand how the jam tables are used > and also makes it possible for a single function to handle all of them, > removing some duplicated code. > > Signed-off-by: Lorenzo Carletti <lorenzo.carletti98@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |