Messages in this thread | | | Subject | Re: [PATCH 15/24] kvm: mmu: Wrap mmu_lock cond_resched and needbreak | From | Paolo Bonzini <> | Date | Wed, 27 Jan 2021 21:55:10 +0100 |
| |
On 27/01/21 21:08, Ben Gardon wrote: > I'm not entirely sure I understand this suggestion. Are you suggesting > we'd have the spinlock and rwlock in a union in struct kvm but then > use a static define to choose which one is used by other functions? It > seems like if we're using static defines the union doesn't add value.
Of course you're right. You'd just place the #ifdef in the struct kvm definition.
You can place static inline functions for lock/unlock in virt/kvm/mmu_lock.h, in order to avoid a proliferation of #ifdefs.
Paolo
| |