lkml.org 
[lkml]   [2021]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] configfs: make directories inherit uid/gid from creator
    > > Currently a non-root process can create directories, but cannot
    > > create stuff in the directories it creates.
    >
    > Isn't that on purpose?

    Is it? What's the use case of being able to create empty directories
    you can't use?
    Why allow their creation in the first place then?

    > > + (void)configfs_setattr(dentry, &ia);
    >
    > No need for (void), here, right?

    Just being clear we're ignoring any potential error return.

    > And this feels like a big user-visible change, what is going to break
    > with this?

    That I don't know, but it's unlikely to break anything, since it's virtually
    impossible to use as it is now. If non-root creates the directory, it's
    currently root-owned, so can only be used by root (or something with
    appropriate caps).
    Something with capabilities will be able to use it even if it is no
    longer owned by root.

    \
     
     \ /
      Last update: 2021-01-27 20:58    [W:7.391 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site