lkml.org 
[lkml]   [2021]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 6/8] preempt/dynamic: Provide preempt_schedule[_notrace]() static calls
    On Wed, Jan 27, 2021 at 01:00:07PM -0600, Josh Poimboeuf wrote:
    > On Wed, Jan 27, 2021 at 07:44:01PM +0100, Peter Zijlstra wrote:
    > > On Wed, Jan 27, 2021 at 10:33:08AM -0600, Josh Poimboeuf wrote:
    > >
    > > > What did you think about .static_call_tramp_key? I could whip up a
    > > > patch later unless you beat me to it.
    > >
    > > Yeah, I'm not sure.. why duplicate information already present in
    > > kallsyms?
    >
    > Well, but it's not exactly duplicating kallsyms. No need to store
    > symbol names, just the pointer relationships. And kallsyms is
    > presumably slow.
    >
    > > There's a fair number of features that already require KALLSYMS, I can't
    > > really be bothered about adding one more (kprobes, function_tracer,
    > > stack_tracer, ftrace_syscalls).
    >
    > Right, but I don't think they rely on KALLSYMS_ALL?

    Scratch that, I forgot about your last hack. (That's what I get for
    emailing during meetings.)

    I mean - your patch is fine... let me just whip up the alternative and
    we can compare.

    --
    Josh

    \
     
     \ /
      Last update: 2021-01-27 20:05    [W:6.980 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site