lkml.org 
[lkml]   [2021]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [EXT] Re: [PATCH v4 net-next 11/19] net: mvpp2: add spinlock for FW FCA configuration path
Date
> > index 9d8993f..f34e260 100644
> > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
> > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
> > @@ -1021,6 +1021,11 @@ struct mvpp2 {
> >
> > /* CM3 SRAM pool */
> > struct gen_pool *sram_pool;
> > +
> > + bool custom_dma_mask;
> > +
> > + /* Spinlocks for CM3 shared memory configuration */
> > + spinlock_t mss_spinlock;
>
> Does this need to be a stand-alone patch? This introduces a spinlock, but
> does not use it.
>
> Also, is the introduction of custom_dma_mask in this commit on purpose?

I would add this change to another patch. custom_dma_mask should be removed.

Thanks,
Stefan.
\
 
 \ /
  Last update: 2021-01-27 19:32    [W:0.112 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site