Messages in this thread | | | From | Stefan Chulski <> | Subject | RE: [EXT] Re: [PATCH v4 net-next 11/19] net: mvpp2: add spinlock for FW FCA configuration path | Date | Wed, 27 Jan 2021 18:27:07 +0000 |
| |
> > index 9d8993f..f34e260 100644 > > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h > > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h > > @@ -1021,6 +1021,11 @@ struct mvpp2 { > > > > /* CM3 SRAM pool */ > > struct gen_pool *sram_pool; > > + > > + bool custom_dma_mask; > > + > > + /* Spinlocks for CM3 shared memory configuration */ > > + spinlock_t mss_spinlock; > > Does this need to be a stand-alone patch? This introduces a spinlock, but > does not use it. > > Also, is the introduction of custom_dma_mask in this commit on purpose?
I would add this change to another patch. custom_dma_mask should be removed.
Thanks, Stefan.
| |