lkml.org 
[lkml]   [2021]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mm/page_owner: Use helper function zone_end_pfn() to get end_pfn
From
Date
On 23.01.21 08:05, Miaohe Lin wrote:
> Commit 108bcc96ef70 ("mm: add & use zone_end_pfn() and zone_spans_pfn()")
> introduced the helper zone_end_pfn() to calculate the zone end pfn. But
> pagetypeinfo_showmixedcount_print forgot to use it. And the initialization
> of local variable pfn is duplicated, remove one.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> mm/page_owner.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/page_owner.c b/mm/page_owner.c
> index af464bb7fbe7..d15c7c4994f5 100644
> --- a/mm/page_owner.c
> +++ b/mm/page_owner.c
> @@ -263,8 +263,8 @@ void pagetypeinfo_showmixedcount_print(struct seq_file *m,
> struct page *page;
> struct page_ext *page_ext;
> struct page_owner *page_owner;
> - unsigned long pfn = zone->zone_start_pfn, block_end_pfn;
> - unsigned long end_pfn = pfn + zone->spanned_pages;
> + unsigned long pfn, block_end_pfn;
> + unsigned long end_pfn = zone_end_pfn(zone);
> unsigned long count[MIGRATE_TYPES] = { 0, };
> int pageblock_mt, page_mt;
> int i;
>

Looks a little weird that we initialize "end_pfn" directly and "pfn"
not. I'd make this consistent.

Anyhow

Reviewed-by: David Hildenbrand <david@redhat.com>

--
Thanks,

David / dhildenb

\
 
 \ /
  Last update: 2021-01-26 12:46    [W:1.926 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site