lkml.org 
[lkml]   [2021]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mm/filemap: Remove redundant variable's assignment
From
Date


在 2021/1/26 7:22, Andrew Morton 写道:
> On Mon, 25 Jan 2021 11:20:02 +0800 Baolin Wang <baolin.wang@linux.alibaba.com> wrote:
>
>> We've already set the variable 'i' 's initial value before using it,
>> thus remove redundant previous assignment of variable 'i'.
>>
>> ...
>>
>> --- a/mm/filemap.c
>> +++ b/mm/filemap.c
>> @@ -2472,7 +2472,6 @@ ssize_t generic_file_buffered_read(struct kiocb *iocb,
>> if ((iocb->ki_flags & IOCB_WAITQ) && written)
>> iocb->ki_flags |= IOCB_NOWAIT;
>>
>> - i = 0;
>> pg_nr = generic_file_buffered_read_get_pages(iocb, iter,
>> pages, nr_pages);
>> if (pg_nr < 0) {
>
> Matthew's patch series "Refactor generic_file_buffered_read "
> (https://lkml.kernel.org/r/20210122160140.223228-1-willy@infradead.org)
> changes all this code - I dont think the patch is relevant after that,
> so I'll skip it.

Ah, right. Thanks for letting me know.

\
 
 \ /
  Last update: 2021-01-26 11:44    [W:0.052 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site