lkml.org 
[lkml]   [2021]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 176/199] net: mscc: ocelot: allow offloading of bridge on top of LAG
    Date
    From: Vladimir Oltean <vladimir.oltean@nxp.com>

    commit 79267ae22615496655feee2db0848f6786bcf67a upstream.

    The blamed commit was too aggressive, and it made ocelot_netdevice_event
    react only to network interface events emitted for the ocelot switch
    ports.

    In fact, only the PRECHANGEUPPER should have had that check.

    When we ignore all events that are not for us, we miss the fact that the
    upper of the LAG changes, and the bonding interface gets enslaved to a
    bridge. This is an operation we could offload under certain conditions.

    Fixes: 7afb3e575e5a ("net: mscc: ocelot: don't handle netdev events for other netdevs")
    Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
    Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
    Link: https://lore.kernel.org/r/20210118135210.2666246-1-olteanv@gmail.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/ethernet/mscc/ocelot_net.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    --- a/drivers/net/ethernet/mscc/ocelot_net.c
    +++ b/drivers/net/ethernet/mscc/ocelot_net.c
    @@ -952,10 +952,8 @@ static int ocelot_netdevice_event(struct
    struct net_device *dev = netdev_notifier_info_to_dev(ptr);
    int ret = 0;

    - if (!ocelot_netdevice_dev_check(dev))
    - return 0;
    -
    if (event == NETDEV_PRECHANGEUPPER &&
    + ocelot_netdevice_dev_check(dev) &&
    netif_is_lag_master(info->upper_dev)) {
    struct netdev_lag_upper_info *lag_upper_info = info->upper_info;
    struct netlink_ext_ack *extack;

    \
     
     \ /
      Last update: 2021-01-26 11:06    [W:4.063 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site